Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

docs: fix the docs to be CommonMark compliant #17163

Open
1 of 4 tasks
Splaktar opened this issue Nov 18, 2021 · 0 comments
Open
1 of 4 tasks

docs: fix the docs to be CommonMark compliant #17163

Splaktar opened this issue Nov 18, 2021 · 0 comments

Comments

@Splaktar
Copy link
Member

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

I'm submitting a ...

  • regression from 1.7.0
  • security issue
  • issue caused by a new browser version
  • other

Current behavior:

Expected / new behavior:

  • dgeni and dgeni-packages can be updated without breaking the markdown rendering of the docs

Minimal reproduction of the problem with instructions:

  1. Update dgeni and dgeni-packages
  2. Run the docs and see rendering issues with markdown.

AngularJS version: 1.8.2
Browser: all

Anything else:

The alternative to this labor intensive task is pinning marked to 0.3.6` as is done in PR #17141.

However, in #17141 (comment), Pete suggested that

Rather than pinning marked we should just fix the docs to be CommonMark compliant.

Splaktar added a commit to DevIntent/material that referenced this issue Nov 18, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages
- before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical)
- after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical)
- fix some npm audit issues

Relates to angular/angular.js#17163. Relates to angular#11881. Relates to angular#12111.
Splaktar added a commit to angular/material that referenced this issue Nov 19, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages
- before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical)
- after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical)
- fix some npm audit issues

Relates to angular/angular.js#17163. Relates to #11881. Relates to #12111.
Splaktar added a commit to angular/material that referenced this issue Nov 22, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages
- before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical)
- after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical)
- fix some npm audit issues

Relates to angular/angular.js#17163. Relates to #11881. Relates to #12111.
superheri pushed a commit to superheri/material that referenced this issue Nov 30, 2021
- Use a resolution override for `marked` to be compatible with latest dgeni-packages
- before: found 64 vulnerabilities (1 low, 43 moderate, 17 high, 3 critical)
- after: found 51 vulnerabilities (1 low, 30 moderate, 17 high, 3 critical)
- fix some npm audit issues

Relates to angular/angular.js#17163. Relates to angular#11881. Relates to angular#12111.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant