Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenrugg
Copy link

@stevenrugg stevenrugg commented Aug 28, 2020

added disclaimer for beginning users

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

added disclaimer for beginning users
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@stevenrugg stevenrugg changed the title Added disclaimer in the first paragraph to beginning users. Added disclaimer about the level of experience required in the first paragraph to beginning users. Aug 28, 2020
@stevenrugg
Copy link
Author

stevenrugg commented Aug 30, 2020 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@stevenrugg
Copy link
Author

stevenrugg commented Aug 30, 2020 via email

@@ -5,6 +5,11 @@

# PhoneCat Tutorial App

*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no
*** This tutorial assumes that the reader has a fundamental knowledge of HTML, CSS, and JavaScript. If you have no

@@ -5,6 +5,11 @@

# PhoneCat Tutorial App

*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no
experience coding or have not been introduced to Javascript, we highly suggest that you take some time
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
experience coding or have not been introduced to Javascript, we highly suggest that you take some time
experience coding or have not been introduced to JavaScript, we highly suggest that you take some time

@@ -5,6 +5,11 @@

# PhoneCat Tutorial App

*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no
experience coding or have not been introduced to Javascript, we highly suggest that you take some time
to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or
to learn the basics of JavaScript by going to [MDN's JavaScript guide](https://developer.mozilla.org/en-US/docs/Web/JavaScript).

*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no
experience coding or have not been introduced to Javascript, we highly suggest that you take some time
to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or
https://www.w3schools.com/js/. ***
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://www.w3schools.com/js/. ***

@Splaktar
Copy link
Member

Also from CI:

Invalid commit message, please fix:

- <subject> must not end with a dot

Commit message was:

docs(tutorial/Tutorial): describe your change...

added disclaimer for beginning users

See https://bit.ly/angular-guidelines

You can find more at https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants