This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
(fix): merge URI query into fragment in non-html5 $location mode. #15865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular does not currently include the non-fragment query portion Of URLs in non-html5 $location mode. This commit merges the fragment Query, if present, with the non-fragment query if it exists. See angular#15856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular does not currently include the non-fragment query portion
Of URLs in non-html5 $location mode. This commit merges the fragment
Query, if present, with the non-fragment query if it exists.
See #15856
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
AngularJS's $location service treats URLs differently depending on whether or not the browser supports the HTML5 history API or requires the use of the hashbang mode. URLs should be parsed into the same object regardless of browser mode. In the current behaviour, query parameters are lost.
What is the new behavior (if this is a feature change)?
In non-HTML5 hashbang mode, the query parameters that appear prior to the fragment identifier (
#) are copied into the fragment identifier before theparseAppUrlfunction is called. Therefore, the query parameters outside of the fragment are included in both html5 and non-html5 modes.Does this PR introduce a breaking change?
Not really.
Please check if the PR fulfills these requirements
Note that docs are essentially added as part of the discussion in the GitHub issue $location does not parse query portion of URL correctly when in non-html5 mode. #15856
Other information:
None.